chindit/Ransom-s-wake
1
0 Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

perf(sites): validate the site once and hand collision the field array

Browse Source 
DiveSite.configure() builds the height field once (TerrainHeightField
validates the data) instead of running the definition validation and
then the field construction again; the composition root relies on the
error returned by configure(). The collision shape takes the field's
row-major elevations directly instead of copying 263k cells one by one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
OlivierandClaude Opus 5.5 committed 2026-10-06 20:52:04 +02:00
1 parent be16d2ee07
commit 682e1f18e5
5 files changed
+14 -16
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

game/world/sites/dive_site.gd
+4 -4
View File
@@ -21,10 +21,10 @@ var _placeholder_count := 0
func configure(definition: DiveSiteDefinition) -> String:
if definition == null:
return "dive site definition is missing"
var error := definition.validation_error()
if not error.is_empty():
return error
var terrain_error := _terrain.configure(definition.height_field())
var field := definition.height_field()
if field == null:
return "dive site definition is invalid"
var terrain_error := _terrain.configure(field)
if not terrain_error.is_empty():
return terrain_error
_definition = definition